fix: bump ops to 2.19 and cleanup NHC installation #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
C-slurm
jedel1043
requested review from
NucciTheBoss and
dsloanm
and removed request for
a team
NucciTheBoss
approved these changes
Mar 3, 2025
|
Looks good to me! Will wait for integration tests to finish successfully before merging |
Sooooo probably good to cleanup the disk for our runner 😅 |
NucciTheBoss
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
LGTM!
I changed the log & artifact retention period to 1 day to flush out the runners. I'll likely update shorten the period to 30 days in the future so that we don't have a big backlog build up.
Also, nice find on this issue here: actions/runner-images#2840. Surprisingly that we have to directly call out to sudo rm -rf * to free up like 10GB of runner space 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
Summary of changes
opsversion on all charms to2.19.dispatchfile for Slurmd.Related Issues, PRs, and Discussions
Fixes #85.
Docs
No docs are required for only bug fixes.