Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: speedup integration tests #66

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

jedel1043
Copy link
Collaborator

@jedel1043 jedel1043 commented Jan 20, 2025

Equivalent to charmed-hpc/filesystem-charms#12 for slurm-charms.

Rewrites the integration tests to build the charms concurrently.

@jedel1043 jedel1043 requested a review from a team as a code owner January 20, 2025 18:49
@jedel1043 jedel1043 requested review from NucciTheBoss and dsloanm and removed request for a team January 20, 2025 18:49
@jedel1043 jedel1043 force-pushed the speedup-tests branch 3 times, most recently from 6c75bf9 to 32d1361 Compare January 21, 2025 01:35
@jedel1043
Copy link
Collaborator Author

CI fails because this changes the deployment order of the charms, making #67 much more probable to trigger.

@NucciTheBoss NucciTheBoss added C-slurm Component: Slurm cleanup This pull request cleans up the project and introduces no functional changes blocked A dependency must be resolved before this is actionable labels Feb 5, 2025
This makes the integration tests start a bit faster by concurrently building all the charms + deploying them in a concurrent way.
@jedel1043 jedel1043 removed the blocked A dependency must be resolved before this is actionable label Feb 20, 2025
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Will be great to have faster integration tests!

@NucciTheBoss NucciTheBoss merged commit f95b09b into charmed-hpc:main Feb 25, 2025
5 checks passed
@jedel1043 jedel1043 deleted the speedup-tests branch February 25, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-slurm Component: Slurm cleanup This pull request cleans up the project and introduces no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants