Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Everest/ccc guide regarding EVerest 2024.9.0 release #28

Conversation

FaHaGit
Copy link
Contributor

@FaHaGit FaHaGit commented Jan 9, 2025

No description provided.

…nagement

Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
…support

Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
…0 release (refs EVEREST-1291)

Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
…ntation

Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
Copy link

@barsnick barsnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, otherwise a great improvement.

**API** (`view on GitHub <https://github.com/EVerest/everest-core/tree/main/modules/API>`__)

This module is not mandatory for an EVSE setup using Charge Control C in EVerest. However, the module
:code:`API` is responsible to provide a simple MQTT based API to EVerest internals.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:code:`API` is responsible to provide a simple MQTT based API to EVerest internals.
:code:`API` is responsible for providing a simple MQTT based API to EVerest internals.

Here is an example of how to change the "connector_type" parameter of the CbTarragonDriver module to
"IEC62196Type2Cable" in the EVerest configuration file.

Snippet of a EVerest configuration file:

.. code-block:: sh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be formatted as YAML, or would that active peculiar colors?

Suggested change
.. code-block:: sh
.. code-block:: yaml

I can't seem to find a proper list of supported languages. I looked at this list. I hope it's the one that applies. sh isn't even mentioned, nor is console.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaml is working

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have changed the types of the other console outputs from sh -> console

Signed-off-by: Fabian Hartung <fabian.hartung@chargebyte.com>
@FaHaGit FaHaGit requested a review from barsnick January 9, 2025 14:18
@FaHaGit FaHaGit merged commit fc0b6da into everest/charge_control_c Jan 10, 2025
1 check passed
@FaHaGit FaHaGit deleted the everest/ccc_update_guide_regarding_EVerest_2024.9.0 branch January 10, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants