Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate all errors #155

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dmartin35
Copy link
Collaborator

@Lawouach
This is the first version of global validation for the experiment syntax.

This is appending/extending a list of Exception instances along the validation line and reporting all errors at once, at the end of experiment validation (before raising a global exception that is matched & logged by the CLI)

Improvement, in this version, for each error we create an instance of a sub class of ChaosException. We might simplify to only handle a list of errors messages as strings.

To be continued, if we choose this solution, the hypothesis module still need to be updated

…rs at once

Signed-off-by: David Martin <david@chaoiq.io>
…list of errors in message

Signed-off-by: David Martin <david@chaosiq.io>
@codecov-io
Copy link

codecov-io commented Dec 27, 2019

Codecov Report

Merging #155 into master will increase coverage by 0.42%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   86.41%   86.83%   +0.42%     
==========================================
  Files          23       23              
  Lines        1627     1664      +37     
==========================================
+ Hits         1406     1445      +39     
+ Misses        221      219       -2
Impacted Files Coverage Δ
chaoslib/provider/process.py 92.15% <100%> (+0.66%) ⬆️
chaoslib/exceptions.py 100% <100%> (ø) ⬆️
chaoslib/hypothesis.py 89.1% <100%> (+0.66%) ⬆️
chaoslib/control/python.py 87.5% <100%> (+0.29%) ⬆️
chaoslib/extension.py 84.9% <100%> (+0.59%) ⬆️
chaoslib/control/__init__.py 87.29% <40%> (+0.14%) ⬆️
chaoslib/activity.py 88.48% <65.21%> (+0.89%) ⬆️
chaoslib/provider/http.py 84.9% <85.71%> (+0.59%) ⬆️
chaoslib/experiment.py 91.89% <88.88%> (+0.17%) ⬆️
chaoslib/provider/python.py 87.17% <93.75%> (+0.87%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44c3bf7...2cacb7b. Read the comment docs.

@Lawouach Lawouach added the viewed Issue has been viewed but not agreed upon yet label Apr 9, 2020
@Lawouach Lawouach marked this pull request as draft July 6, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
viewed Issue has been viewed but not agreed upon yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants