asg support with basic probes #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Batiievskyi <dmitriy@batiyevsky.org>
|
@russmiles @Lawouach are you guys vacationing? :) |
|
Apologies for delay, I’ll get on to this today. |
russmiles
approved these changes
Aug 22, 2018
|
I have discovered minor issues in code we merged previously. I am finishing real-world tests and will be creating new pull request tomorrow and than we will be ready for a release I think |
|
Sounds good @0rc |
|
Maybe we could write a joint blog post on one of those real world cases post the release @0rc ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added just the probes as I cannot think of any actions for an auto-scaling group
Signed-off-by: Dmitry Batiievskyi dmitriy@batiyevsky.org