Disable ForestToParseTree cache when ambiguity='resolve' (issue lark-…

…parser#1283)
chanicpanic · Jun 28, 2024 · 50a8a14 · 50a8a14
1 parent 00d83f9
commit 50a8a14
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lark/parsers/earley.py b/lark/parsers/earley.py
@@ -300,7 +300,7 @@ def parse(self, lexer, start):
 
         if self.Tree is not None:
             # Perform our SPPF -> AST conversion
-            transformer = ForestToParseTree(self.Tree, self.callbacks, self.forest_sum_visitor and self.forest_sum_visitor(), self.resolve_ambiguity)
+            transformer = ForestToParseTree(self.Tree, self.callbacks, self.forest_sum_visitor and self.forest_sum_visitor(), self.resolve_ambiguity, not self.resolve_ambiguity)
             solutions = [transformer.transform(s) for s in solutions]
 
             if len(solutions) > 1:

diff --git a/lark/parsers/earley_forest.py b/lark/parsers/earley_forest.py
@@ -609,9 +609,10 @@ def transform_packed_node(self, node, data):
                 children.append(data.left)
         if data.right is not PackedData.NO_DATA:
             children.append(data.right)
-        if node.parent.is_intermediate:
-            return self._cache.setdefault(id(node), children)
-        return self._cache.setdefault(id(node), self._call_rule_func(node, children))
+        transformed = children if node.parent.is_intermediate else self._call_rule_func(node, children)
+        if self._use_cache:
+            self._cache[id(node)] = transformed
+        return transformed
 
     def visit_symbol_node_in(self, node):
         super(ForestToParseTree, self).visit_symbol_node_in(node)