-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(bouncer): Update sdk to official 1.8.0-beta.1 [WEB-1995] #5712
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
33bb3c0
to
f47674a
Compare
f47674a
to
62ded5c
Compare
3077340
to
181eb62
Compare
181eb62
to
c70d2c1
Compare
// eslint-disable-next-line @typescript-eslint/no-use-before-define | ||
await approveEvmTokenVault( | ||
|
||
await approveErc20( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this will work. The approveErc20
will be done from the wallet address, instead of from the new evmWallet
. We should keep it as it was.
// The SDK returns null if no transaction is sent | ||
if (callback && (await callback(nextEvmNonce[chain]!)) === null) { | ||
return nextEvmNonce[chain]!; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove this? Has the behaviour of the SDK change? Touching this nonce logic is very prone to error.
gasBudget: messageMetadata.gasBudget.toString(), | ||
ccmAdditionalData: messageMetadata.ccmAdditionalData as `0x${string}`, | ||
additionalData: messageMetadata.additionalData, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why changing the ccmAdditionalData
to additionalData
? I guess it's because it's within the ccmParams
so it's a bit redundant to call it ccmAdditionalData
but I'd rather keep it as is to match exactly the naming in the protocol.
No description provided.