Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the infura API id #5

Closed
Thunnini opened this issue Mar 17, 2020 · 0 comments
Closed

Hide the infura API id #5

Thunnini opened this issue Mar 17, 2020 · 0 comments
Assignees
@Thunnini

Comments

@Thunnini
Copy link
Member

Thunnini commented Mar 17, 2020 •
edited
Loading

#2

We use the infura node for ENS. But, currently, the infura API id is hard-coded and visible in https://github.com/everett-protocol/keplr-extension/blob/master/src/config.ts#L9. This is not preferred way even though there is no problem even if this id is disclosed publicly. So, we need to hide such an id by getting API id from the environment variable on building.
@Thunnini Thunnini self-assigned this Mar 17, 2020
@Thunnini Thunnini changed the title Hide the infura API key Hide the infura API id Mar 17, 2020
Thunnini added a commit that referenced this issue Apr 7, 2020
@Thunnini
Add config.var file to hide the endpoint and api keys #5
6a1407f
@Thunnini Thunnini closed this as completed Apr 7, 2020
Thunnini pushed a commit that referenced this issue Oct 1, 2021
@wseungjin
Merge pull request #5 from chainapsis/feature/sign-transaction
e36919e 
feature : disable input of sign transaction , improve ui, add color options
ducnnguyen pushed a commit to AstraProtocol/keplr-wallet that referenced this issue Oct 18, 2022
@nghiachitiki
Merge pull request chainapsis#5 from tikivn/ASW-17/Swap-defi
7588b88 
Asw 17/swap defi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thunnini Thunnini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Thunnini