Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP 307 and 308 status codes are not treated as redirects #147

Closed
JamesMessinger opened this issue Mar 4, 2017 · 6 comments
Closed

HTTP 307 and 308 status codes are not treated as redirects #147

JamesMessinger opened this issue Mar 4, 2017 · 6 comments

Comments

@JamesMessinger
Copy link
Member

Not sure if this is by design or not, but the .redirect and .redirectTo assertions currently only test for 301, 302, and 303 status codes. Shouldn't this list also include HTTP 307 (Temporary redirect) and HTTP 308 (Permanent redirect)?
JamesMessinger added a commit to JamesMessinger/postman-bdd that referenced this issue Mar 4, 2017
@JamesMessinger
Treat HTTP 307 and 308 response codes as redirects (see chaijs/chai-h…
2ec54f0 
…ttp#147)
@vieiralucas
Copy link
Member

vieiralucas commented Mar 6, 2017 •
edited
Loading

Hello @BigstickCarpet, thanks for your issue.

It seems reasonable to me that chait-http could support 307 and 308 on the .redirect and .redirectTo assertions.

It looks like you already know where to fix that, would you like to make a PR?

@JamesMessinger
Copy link
Member Author

Ok, I'll submit a PR when I get a free moment. May not be for a few weeks though, because I'm about to leave for vacation

@keithamus
Copy link
Member

but the commit is right there! 😨

@JamesMessinger
Copy link
Member Author

hahaha... gotta fork the repo, checkout, branch, commit, test, open a PR... Ain't nobody got time for that! 😸

tonymet pushed a commit to tonymet/chai-http that referenced this issue Mar 13, 2017
Fixes chaijs#147 add 307,308 to redirect assertion
3a72429
tonymet pushed a commit to tonymet/chai-http that referenced this issue Mar 13, 2017
add 307,308 to redirect assertion chaijs#147
7eef16a
@tonymet
Copy link

tonymet commented Mar 13, 2017

Added PR #154 with @BigstickCarpet 's change. Thanks all this was a blocker for us too :D

keithamus added a commit that referenced this issue Mar 15, 2017
@keithamus
Merge pull request #154 from tonymet/issue/147
1ea9265 
add 307,308 to redirect assertion #147
@vieiralucas
Copy link
Member

Closed by #154

This was referenced May 4, 2020
Closed
Closed
Merged
Closed
Merged
@snyk-bot snyk-bot mentioned this issue Jun 25, 2021
Merged
@snyk-bot snyk-bot mentioned this issue Jul 15, 2021
Open
@snyk-bot snyk-bot mentioned this issue Jul 30, 2021
Open
@snyk-bot snyk-bot mentioned this issue Aug 12, 2021
Merged
@snyk-bot snyk-bot mentioned this issue Sep 3, 2021
Open
@snyk-bot snyk-bot mentioned this issue Sep 20, 2021
Merged
@snyk-bot snyk-bot mentioned this issue Nov 27, 2021
Closed
@snyk-bot snyk-bot mentioned this issue Sep 25, 2022
Open
@rcsl rcsl mentioned this issue Oct 5, 2022
Open
@snyk-bot snyk-bot mentioned this issue Dec 30, 2022
Merged
@enterstudio enterstudio mentioned this issue Jan 9, 2023
Open
@mglantz mglantz mentioned this issue Jan 9, 2023
Open
@leeyeekee leeyeekee mentioned this issue Jan 9, 2023
Open
@ajboxjr ajboxjr mentioned this issue Jan 9, 2023
Open
@vpnj012k vpnj012k mentioned this issue Jan 17, 2023
Open
@smkorde smkorde mentioned this issue Jan 17, 2023
Open
@simbo1905 simbo1905 mentioned this issue Jan 18, 2023
Open
@enterstudio enterstudio mentioned this issue Jan 18, 2023
Open
This was referenced Jan 18, 2023
Open
Open
Open
Open
Open
Open
Open
Open
@MaxMood96 MaxMood96 mentioned this issue Jan 18, 2023
Open
This was referenced Jan 18, 2023
Open
Open
@DavidBraun777 DavidBraun777 mentioned this issue Jan 18, 2023
Open
@snyk-bot snyk-bot mentioned this issue Jan 18, 2023
Open
@demo-manish demo-manish mentioned this issue Jan 18, 2023
Open
@ekmixon ekmixon mentioned this issue Jan 18, 2023
Open
This was referenced Jan 18, 2023
Open
Open
Open
Open
@alanwill alanwill mentioned this issue Jan 19, 2023
Open
@rcsl rcsl mentioned this issue Jan 19, 2023
Open
@SARAN-thala SARAN-thala mentioned this issue Jan 19, 2023
Open
This was referenced Jan 20, 2023
Open
Open
@danielduhh danielduhh mentioned this issue Jan 24, 2023
Open
@bparrish206 bparrish206 mentioned this issue Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@keithamus @tonymet @JamesMessinger @vieiralucas