usermod/groups: use checked malloc

usermod.c:2157:24: warning: dereference of possibly-NULL ‘user_groups’ [CWE-690] [-Wanalyzer-possible-null-dereference]
cgzones · Mar 31, 2023 · acbe3d0 · acbe3d0
1 parent e5905c4
commit acbe3d0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/groups.c b/src/groups.c
@@ -91,7 +91,7 @@ int main (int argc, char **argv)
 	GETGROUPS_T *groups;
 
 	sys_ngroups = sysconf (_SC_NGROUPS_MAX);
-	groups = MALLOCARRAY (sys_ngroups, GETGROUPS_T);
+	groups = XMALLOCARRAY (sys_ngroups, GETGROUPS_T);
 
 	(void) setlocale (LC_ALL, "");
 	(void) bindtextdomain (PACKAGE, LOCALEDIR);

diff --git a/src/usermod.c b/src/usermod.c
@@ -2152,7 +2152,7 @@ int main (int argc, char **argv)
 #endif
 
 	sys_ngroups = sysconf (_SC_NGROUPS_MAX);
-	user_groups = MALLOCARRAY (sys_ngroups + 1, char *);
+	user_groups = XMALLOCARRAY (sys_ngroups + 1, char *);
 	user_groups[0] = NULL;
 
 	is_shadow_pwd = spw_file_present ();