Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use jsonld in tests #8

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Update to use jsonld in tests #8

merged 1 commit into from
Sep 30, 2024

Conversation

C-Loftus
Copy link
Member

@C-Loftus C-Loftus commented Sep 30, 2024

previous code used json and replaced the properties key. This tests the template by using the raw jsonld from https://api.iodh.internetofwater.app/collections/usgs-sta/items/'AR008-331856091114601'?f=jsonld
otherwise all other code is the same.

Still using local tests instead of gcr since we would need to encode the data to send it to the endpoint and then it is non-trivial to decode it and ensure it is valid JSON and hasn't been escaped. Can be switched to in future, just don't think its a priority.

@C-Loftus C-Loftus requested a review from webb-ben September 30, 2024 17:31
@C-Loftus C-Loftus merged commit 0c2c1f2 into main Sep 30, 2024
1 check passed
@C-Loftus C-Loftus deleted the jsonld branch September 30, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants