Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated Google Drive Android API #59

Closed
wants to merge 6 commits into from

Conversation

oneseedfruit
Copy link

Which was causing sign-in to get stuck at the pop-up after tapping on an account.

This fixes #58.

…tuck at a pop-up after tapping on an account.
@@ -176,7 +177,7 @@ class PlayGameServicesGodot(godot: Godot) : GodotPlugin(godot), AchievementsList
this.saveGameName = saveGameName
val signInOptions = if (enableSaveGamesFunctionality) {
val signInOptionsBuilder = GoogleSignInOptions.Builder(GoogleSignInOptions.DEFAULT_GAMES_SIGN_IN)
signInOptionsBuilder.requestScopes(Drive.SCOPE_APPFOLDER).requestId()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.requestId() should still be there though?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason if .requestId() is left there, it'll also cause the sign-in to get stuck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants