Design Review - Errors & Warnings - Part 2

[shindigira]

closes #538
closes #539
closes #542
closes #551

More changes (05/21/2024)

• content(errors/warnings): error/warnings counts and table rows use commas (e.g. 1,000)
• stylefix(table): hidden table borders are now present again on single/register fields
• content(errors/warnings): record/records changed to 'found'

More changes (05/20/2024)

• style(success error/warnings alert): reduced margin-bottom to 30px (30px between success alert and Filing Nav Buttons)
• style(warnings): verify text limited to 670px, well limited to 770px
• style(warnings): multifield warnings now also has table borders
• feat(errors & warnings): Updated the count to be the rows affected by errors/warnings
• content(errors/warnings): added 'record' or 'records' word to count statement

Changes

• style(single/multi/register errors): 45px margin-bottom
• style(tables): only multifield errors tables have borders,
• content(errors): removed bottom alerts
• style(errors/warnings - success): use negative margin (ensures 30px from alert to filing nav buttons)
• content(errors): "there is" instead of "there may be"
• style(warnings): restrict header to 670px
• enhancement(warnings): Reworked warnings alert logic

How to test (dev)

The only functionality changes are in:

• enhancement(warnings): Reworked warnings alert logic -- see FilingWarningsAlerts.tsx
• feat(errors & warnings): Updated the count to be the rows affected by errors/warnings -- see getRecordsAffected function.

Note

• Once deployed, @natalia-fitzgerald can verify

[meissadia]

Code looks good, awesome work navigating the complexities of these components!

There does seem to be some inconsistency with table borders. Based on the design file I see three scenarios:

• Paginated table => has border on all sides
• Horizontally scrollable table => Has border on top + left + bottom
• Fully displayed table => Only has bottom border

---

I'm currently seeing some "fully displayed tables" with all borders, which seems incorrect. (sorry, I can't seem to find which test file this was generated with).

---

I also see some paginated tables with only the bottom border, when I would expect all borders.

• Test file: logic-errors_medium.csv
  

[shindigira]

@meissadia Thanks for the thorough review and noticing the tables border styling wonkiness.

Currently, what you see is by intent; the style requirements for table borders from @natalia-fitzgerald are as:

1. Singlefield/Register-level errors and warnings don't have the full borders styling; the bottom border comes from the last table row <tr /> element of the table.
2. Multifield errors and warnings have the full borders styling.
3. The "hidden table" on the last page of paginated tables has the full borders styling.

In a later PR, we will address this specific styling issue: #547 (comment)

[meissadia]

@shindigira Thanks for the clarification.