Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Icon): Use BEM for Icon modifier classes #364

Merged
merged 2 commits into from
Jun 7, 2024
Merged

fix(Icon): Use BEM for Icon modifier classes #364

merged 2 commits into from
Jun 7, 2024

Conversation

meissadia
Copy link
Contributor

@meissadia meissadia commented Jun 4, 2024 •
edited
Loading

Process

  • I've confirmed that upgrading to the latest cfpb-icons library is the source of the breakage, causing the updating icons to no longer be animated
  • I've confirmed that other icon modifiers (ex. Success alert icon shown in green) seem to be working as expected.

How to test this PR

  1. Visit https://deploy-preview-364--cfpb-design-system-react.netlify.app/?path=/story/components-draft-icons--status-icons
  2. Confirm that the updating icon is animated

@netlify Netlify
Copy link

netlify bot commented Jun 4, 2024 •
edited
Loading

✅ Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit ceaa542
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/665f52fe305dce0008c3d108
😎 Deploy Preview https://deploy-preview-364--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

shindigira
shindigira previously approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@shindigira shindigira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome fix!

@meissadia meissadia enabled auto-merge (squash) June 4, 2024 17:47
@meissadia meissadia requested a review from shindigira June 4, 2024 17:48
@meissadia
Copy link
Contributor Author

@shindigira Thanks for the quick review! Requesting re-review because I needed to update broken unit tests.

billhimmelsbach
billhimmelsbach approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having some of the classes updated is a little tricky... ok for now though 👍

@meissadia meissadia merged commit 49cadaa into main Jun 7, 2024
8 of 10 checks passed
@meissadia meissadia deleted the fix-updating-icon-animation branch June 7, 2024 03:09
@billhimmelsbach billhimmelsbach mentioned this pull request Jun 7, 2024
Merged
billhimmelsbach added a commit to cfpb/sbl-frontend that referenced this pull request Jun 9, 2024
@billhimmelsbach
deps(dsr): bump for spinner fix (#672)
f0094bc 
**For pre-clearance**

We need to bump the DSR to get this great @meissadia [fix for the
loading spinners](cfpb/design-system-react#364)!

## Changes

- update the DSR to get the loading spinner fix

## How to test this PR

1. Do loading spinner work again?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhimmelsbach billhimmelsbach billhimmelsbach approved these changes

@shindigira shindigira Awaiting requested review from shindigira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meissadia @shindigira @billhimmelsbach