feat(Table): Added three props to control wrapping in the Table component #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
meissadia
suggested changes
May 15, 2024
meissadia
approved these changes
May 15, 2024
| @@ -158,3 +158,26 @@ export const FixedWidth: Story = { | |||
| ] | |||
| } | |||
| }; | |||
|
|
|||
| const maxUidTestRows = [...Array.from({ length: 20 }).keys()].map( | |||
There was a problem hiding this comment.
I'm still curious why even 20 rows are needed? The character count of every row is exactly the same. I'd even argue that having a single row of demo data would be easier for users to adjust props on (especially since changing the prop configuration requires editing the array directly).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #344
Changes
cellDisableWordWrap,cellWordBreakandheaderWordWrapprops to Table columnsHow to test
cellDisableWordWrap,cellWordBreakandheaderWordWrapin theLongCharacterSetsTable story.Screenshots
Default
Column 1 cells -
no-wrap, Column 2 cells -wrap