Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ButtonGroup][Checkbox] Minor fixes #297

Merged
merged 3 commits into from
Feb 7, 2024
Merged

[ButtonGroup][Checkbox] Minor fixes #297

merged 3 commits into from
Feb 7, 2024

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented Jan 31, 2024 •
edited
Loading

closes #298

Changes

  • ButtonGroup - Allows additional style changes via className prop
  • Checkbox - three props (labelClassName, labelInline, status) are now optional to prevent TypeScript errors in apps

@netlify Netlify
Copy link

netlify bot commented Jan 31, 2024 •
edited
Loading

✅ Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit 4f2d646
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/65c3b3b78b0b6400089419a3
😎 Deploy Preview https://deploy-preview-297--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shindigira shindigira changed the title [ButtonGroup] Allows additional styling via className prop [ButtonGroup][Checkbox] Minor fixes Feb 7, 2024
meissadia
meissadia approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@shindigira shindigira merged commit c1b043d into main Feb 7, 2024
7 of 9 checks passed
@shindigira shindigira deleted the buttongroup-classname branch February 7, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meissadia meissadia meissadia approved these changes

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach billhimmelsbach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement][ButtonGroup] Allows additional styling via className prop
2 participants
@shindigira @meissadia