Improve focus of test coverage reporting #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e .svg import issues in vitest
Upgrade @vitejs/plugin-react to 4.2.1 Upgrade @vitest/coverage-istanbul to 1.2.1
…r it's Option elements
- Allow DS to render its own icons - Resolve SVG import error
fix: Explicitly set test.coverage.all = false
…ually testing anything
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
meissadia
requested review from
shindigira and
billhimmelsbach
as code owners
meissadia
changed the title
|
Merge conflicts have been resolved. Ready for review. |
billhimmelsbach
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
This is really great @meissadia. Thanks for checking this out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR builds upon #206, so will wait until those changes are merged before moving forward with revew.Closes #290
Tests that imported components from the main DSR export (
src/index.ts) caused the coverage report to include info on all of the components in DSR.This PR imports components directly from their implementation files, allowing devs to focus on the test coverage of only the elements involved in the tests being run.
Changes
How to test this PR
yarn test divideryarn test