Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Navbar] Add ResponsiveMenu component #379

Closed
ojbravo opened this issue Sep 19, 2024 · 0 comments · Fixed by #380
Closed

[Navbar] Add ResponsiveMenu component #379

ojbravo opened this issue Sep 19, 2024 · 0 comments · Fixed by #380
Assignees
@ojbravo

Comments

@ojbravo
Copy link
Collaborator

ojbravo commented Sep 19, 2024 •
edited
Loading

Add ResponsiveMenu to DSR
Add unit tests for ResponsiveMenu
Update mobile spacing for Footer links

Mockups:
mobile-menu

Actual Screenshots:
Note - All spacing and functionality is consistent with consumerfinance.gov.

Collapsed Menu
Screenshot 2024-09-24 at 11 05 27 AM

Expanded Menu with hover:
Screenshot 2024-09-24 at 10 57 03 AM

Footer Links with horizontal spacing:
Screenshot 2024-09-27 at 4 08 16 PM
@ojbravo ojbravo self-assigned this Sep 19, 2024
@ojbravo ojbravo mentioned this issue Sep 27, 2024
Merged
meissadia added a commit that referenced this issue Oct 29, 2024
@ojbravo @meissadia
379-ResponsiveMenu (#380)
d974783 
Closes #379.

- Added ResponsiveMenu component
- Added unit tests for ResponsiveMenu component
- Added horizontal spacing to Footer links for mobile screens

## Screenshots (Mobile)

### Logged out - No links

![logged-out](https://github.com/user-attachments/assets/8bda772b-872e-485e-8ed1-3d2999845798)

### Logged in - Collapsed

![collapsed](https://github.com/user-attachments/assets/f22fc19c-9e4f-4bd9-8ba5-4cebc9f67187)

### Logged in - Open w/ hover

![open-hover](https://github.com/user-attachments/assets/63571e65-1c06-490a-9777-41b2bb396cb0)

---------

Co-authored-by: Meis <meissadia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ojbravo ojbravo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

379-ResponsiveMenu cfpb/design-system-react
1 participant
@ojbravo