Cleanup statedb test #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hangeEvents in filter event system
- compare struct fields to avoid failure when rlp bytes out of order
The pendingStorage value is wiped away on every updateTrie, but we need it so store the diffStorage so we send accurate, minimal statediffs. Take a look at Commit in statedb because you should be able to skip empty diffStorage entries as well, currently those get sent.
VDB-1523: Track diffStorage for accurate stateDiffs
Order was mattering for the account diffs and storage diffs inside the payload, and it doesn't matter in real life. This made for a flaky test.
We don't use it, it's unnecessary.
i-norden
pushed a commit
that referenced
this pull request
Oct 16, 2020
* ovm: new initial state * ovm: initial testnet state tests * initial state: update * state: update contracts * initial state: document deployment addresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a draft so I can see this as a PR.