Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad character f5 vs and pool #932

Merged
merged 1 commit into from
Mar 29, 2018

Conversation

cgagnaire
Copy link
Contributor

Fix bad first character in long and short outputs of virtual servers and pools name of F5 BigIP plugin.

}
$result->{Name} =~ s/^.//;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really odd to fix it this way. Do we have on the root cause of this first random char ? Is this chr provoking it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that odd. The names are built from oid indexes that are ASCII translation of the names. But there always is a random charactere in first position.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roger that, just wonder why this char is popping ... let's merge to let everybody get access to this fix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I know, hope its not a bug from my f5 box...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to test it against our snmp simulator on friday. we got one walk from other user ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already tested, and there is no pools or virtualservers :/

}
$result->{Name} =~ s/^.//;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on poolstatus

Thanks

@Sims24 Sims24 merged commit 3cd1e71 into centreon:master Mar 29, 2018
@cgagnaire cgagnaire deleted the 930-fix-bad-character-f5-vs branch March 29, 2018 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants