add modes trunks and list-trunks #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2018
Sims24
reviewed
Mar 29, 2018
| next; | ||
| } | ||
|
|
||
| if (!defined($self->{option_results}->{use_regexp}) && $self->{result}->{$sysTrunkName . '.' . $instance} eq $self->{option_results}->{name}) { |
There was a problem hiding this comment.
We use to add the following condition to similar loop/filter :
&& $self->{option_results}->{name} ne ''
Any reason we change this here ?
There was a problem hiding this comment.
Yes, I could have use filter_name option, but was wrongly inspired by other list modes from this plugin.
There was a problem hiding this comment.
Ok, as they are new modes and we do not risk to break anything please make it "standard"
| push @{$self->{trunks_selected}}, $instance; | ||
| next; | ||
| } | ||
| if (defined($self->{option_results}->{use_regexp}) && $self->{result}->{$sysTrunkName . '.' . $instance} =~ /$self->{option_results}->{name}/) { |
|
@cgagnaire my review is about why do we have to specify --regexp option. Why do not use regexp by default as we do recently for other devices ? Any technical reason on f5 size or oid values ? |
|
Ok let's merge this to avoid unifying all the f5 plugin stack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add modes trunks and list-trunks to F5 BigIP plugin.