SNMP: STP: Allow custom topologies #912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow topology overwrite with `--stp-overwrite-status`, * There are no security checks for the option, * If port is disabled, it will be skipped anyway. _Usage:_ `--stp-overwrite-status 21@blocking:22@forwarding` Option is `--stp-overrite-status` each port are defined with `<port>@<needed status>` and separated with colon. In this example port `21` should be `blocking` and port `22` should be `forwarding` (`22@forwarding` is useless as it is default one) Signed-off-by: nailyk-fr <nailyk_git@nailyk.fr>
* With this patch, if an interface is provided as disabled from `stp-overwrite-status` option, do not skip it to report CRITICAL if necessary. Signed-off-by: nailyk-fr <nailyk_git@nailyk.fr>
|
Closing this one. Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those PS will allow custom topologies, as mentioned in #780
This is not perfect as it:
(scalar $#stp_overwrite_status)+1is now replaced with(scalar @stp_overwrite_status)as it is more readable, accurate, and do not require the+1which can lead in miss-reading the array. (same here master...nailyk-fr:master#diff-be436d687f581cbfaf7fa9f480ae2287R162 but does not really matters)Thanks :)
CC: @Sims24