Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(plugin): add Centreon header for Meraki api calls #5207

Merged
merged 1 commit into from
Sep 30, 2024
Merged

enh(plugin): add Centreon header for Meraki api calls #5207

merged 1 commit into from
Sep 30, 2024

Conversation

sdepassio
Copy link
Contributor

@sdepassio sdepassio commented Sep 27, 2024 •
edited
Loading

Centreon team

Description

Add partner key to Meraki API calls

Fixes CTOR-864

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@sdepassio sdepassio marked this pull request as ready for review September 30, 2024 07:06
@sdepassio sdepassio requested a review from a team as a code owner September 30, 2024 07:06
@sdepassio sdepassio changed the title Add Centreon header for api calls enh(plugin): add Centreon header for api calls Sep 30, 2024
@sdepassio sdepassio changed the title enh(plugin): add Centreon header for api calls enh(plugin): add Centreon header for Meraki api calls Sep 30, 2024
@lucie-dubrunfaut lucie-dubrunfaut merged commit e0033d0 into develop Sep 30, 2024
21 checks passed
@lucie-dubrunfaut lucie-dubrunfaut deleted the CTOR-864-add-partner-key-to-meraki-api-calls branch September 30, 2024 12:34
sfarouq-ext pushed a commit that referenced this pull request Oct 3, 2024
@sdepassio @sfarouq-ext
enh(plugin): add Centreon header for Meraki api calls (#5207)
c94d46c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omercier omercier omercier approved these changes

@lucie-dubrunfaut lucie-dubrunfaut Awaiting requested review from lucie-dubrunfaut lucie-dubrunfaut is a code owner automatically assigned from centreon/owners-perl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdepassio @omercier @lucie-dubrunfaut