Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin) Linux local - mode systemd-journal : --output-fields added in version 236 #5180

Merged
merged 9 commits into from
Oct 4, 2024

Conversation

s-duret
Copy link
Contributor

@s-duret s-duret commented Sep 10, 2024

Description

--output-fields has been added in journalctl version 236.
We should remove this option for older versions.

Fixes # CTOR-877

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.

@garnier-quentin
Copy link
Contributor

Hi @s-duret. You shouldn't use awk but an perl regex to check the version.

@s-duret
Copy link
Contributor Author

s-duret commented Sep 10, 2024

Hi @garnier-quentin
Thanks for your feedback.
Is it better?

@s-duret s-duret changed the title --output-fields added in version 236 fix(plugin) Linux local - mode systemd-journal : --output-fields added in version 236 Sep 10, 2024
@s-duret s-duret marked this pull request as ready for review September 10, 2024 13:38
@s-duret s-duret requested a review from a team as a code owner September 10, 2024 13:38
@s-duret s-duret requested a review from Evan-Adam September 10, 2024 13:38
@lucie-dubrunfaut lucie-dubrunfaut added the bugfix fixing bug (PR Only) label Sep 10, 2024
@lucie-dubrunfaut lucie-dubrunfaut added the internal Centreon internal PR label Sep 23, 2024
@omercier omercier requested a review from a team as a code owner September 30, 2024 07:17
omercier
omercier previously approved these changes Sep 30, 2024
Co-authored-by: sdepassio <114986849+sdepassio@users.noreply.github.com>
@omercier omercier merged commit ab7218d into develop Oct 4, 2024
21 checks passed
@omercier omercier deleted the CTOR-877 branch October 4, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix fixing bug (PR Only) internal Centreon internal PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants