This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Fix bug that can cause the timestamp to be 1 second later. #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chingor13
approved these changes
Apr 5, 2018
src/Trace/Span.php
Outdated
| } elseif (!$when instanceof \DateTimeInterface) { | ||
| throw new \InvalidArgumentException('Invalid date format. Must be a \DateTimeInterface or numeric.'); | ||
| } | ||
| $when->setTimezone(new \DateTimeZone('UTC')); | ||
| return $when; | ||
| } | ||
|
|
||
| /** | ||
| * Converst a float timestamp into a \DateTimeInterface object. |
|
Oops, we aren't providing env var credentials to forked builds for CI - investigating. |
chingor13
suggested changes
Apr 5, 2018
src/Trace/Span.php
Outdated
| } elseif (!$when instanceof \DateTimeInterface) { | ||
| throw new \InvalidArgumentException('Invalid date format. Must be a \DateTimeInterface or numeric.'); | ||
| } | ||
| $when->setTimezone(new \DateTimeZone('UTC')); | ||
| return $when; | ||
| } | ||
|
|
||
| /** | ||
| * Converts a float timestamp into a \DateTimeInterface object. | ||
| * |
There was a problem hiding this comment.
PHP code style enforcer found: extra whitespace at end of this line.
src/Trace/Span.php
Outdated
| * @param float $when The Unix timestamp to be converted. | ||
| * @return \DateTimeInterface | ||
| */ | ||
| private function formatFloatTimeToDate($when) { |
There was a problem hiding this comment.
PHP code style enforcer found: opening brace should go on new line.
|
Thanks @chingor13, unfortunately I couldn't find instructions to do this format checks and run tests, etc. and I am super new in php so I have no idea what to do. |
chingor13
reviewed
Apr 5, 2018
src/Trace/Span.php
Outdated
| list($usec, $sec) = explode(' ', microtime()); | ||
| $micro = sprintf("%06d", $usec * 1000000); | ||
| $when = new \DateTime(date('Y-m-d H:i:s.' . $micro)); | ||
| $when = formatFloatTimeToDate(microtime(true)); |
There was a problem hiding this comment.
$when = $this->formatFloatTimeToDate(microtime(true));
src/Trace/Span.php
Outdated
| // Expect that this is a timestamp | ||
| $micro = sprintf("%06d", ($when - floor($when)) * 1000000); | ||
| $when = new \DateTime(date('Y-m-d H:i:s.'. $micro, (int) $when)); | ||
| $when = formatFloatTimeToDate($when); |
There was a problem hiding this comment.
$when = $this->formatFloatTimeToDate($when);
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen because time was read twice when $when was null, once to get the usec and once to get the seconds, so if the initial time was 1.999 and second time was 2.001 then the result will be 2.999 which is 1 second later.