Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Public SetCell #83

Closed
Wondertan opened this issue Apr 27, 2022 · 0 comments · Fixed by #92
Closed

api: Public SetCell #83

Wondertan opened this issue Apr 27, 2022 · 0 comments · Fixed by #92
Labels
enhancement New feature or request

Comments

@Wondertan
Copy link
Member

Currently, only a private setCell method is used internally to set repaired cells, while we can enable it publicly so that API users can fill cells/shares on the fly during the repairing process. Currently, a user has to alter the flattened data square slice imported with importing helper, which requires a relatively complicated formula) to calculate cell position. Instead, users would benefit from public coordinates based SetCell.

Additionally, SetCell should allow setting values only for the nil cells to prevent breaking the integrity of the imported square verified by the imported and cached roots.. This also means that public SetCell won't need to reset roots like its private bro setCell does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant