Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Cache codec and tree constructor in EDS after import #82

Closed
Wondertan opened this issue Apr 27, 2022 · 0 comments · Fixed by #93
Closed

api: Cache codec and tree constructor in EDS after import #82

Wondertan opened this issue Apr 27, 2022 · 0 comments · Fixed by #93
Assignees
@adlerjohn
Labels
enhancement New feature or request

Comments

@Wondertan
Copy link
Member

Importing of EDS requires a user to pass codec and tree constructor. Also, the Repair method requires passing these repeatedly on each repair retry, also allowing the user to change roots and codec on already imported eds. Instead, importing should cache those values and reuse them on Repair.
@adlerjohn adlerjohn moved this to TODO in Celestia Node Apr 27, 2022
@adlerjohn adlerjohn added the enhancement New feature or request label Apr 27, 2022
@Wondertan Wondertan mentioned this issue Apr 27, 2022
Closed
@liamsi liamsi mentioned this issue Apr 27, 2022
Closed
@adlerjohn adlerjohn self-assigned this Jun 14, 2022
@adlerjohn adlerjohn moved this from TODO to In Progress in Celestia Node Jun 14, 2022
@adlerjohn adlerjohn mentioned this issue Jun 14, 2022
Merged
Repository owner moved this from In Progress to Done in Celestia Node Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adlerjohn adlerjohn

Labels
enhancement New feature or request
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cache codec and tree func. celestiaorg/rsmt2d
2 participants
@adlerjohn @Wondertan