Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump go version to match the go.mod #4132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tty47
Copy link
Contributor

@tty47 tty47 commented Feb 21, 2025

helloo team! 👋

small one, just bumping the docker versions to match the go.mod

best!

Signed-off-by: Jose Ramon Mañes <jose@celestia.org>
@github-actions github-actions bot added the external Issues created by non node team members label Feb 21, 2025
@tty47 tty47 added ci:docker Related to docker + dockerhub flow docker Pull requests that update Docker code labels Feb 21, 2025
@tty47 tty47 self-assigned this Feb 21, 2025
@tty47 tty47 changed the title chore: bump go versoin to match the go.mod chore: bump go version to match the go.mod Feb 21, 2025
@@ -1,4 +1,4 @@
FROM --platform=$BUILDPLATFORM docker.io/golang:1.23-alpine3.20 AS builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.23 uses latest golang within 1.23 family, the image is updated in docker registry on each patch release an right now points to 1.23.6

https://hub.docker.com/_/golang

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello!
okay, so this one is not needed then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docker Related to docker + dockerhub flow docker Pull requests that update Docker code external Issues created by non node team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants