Code

header: hardening syncing logic#334

Code

Merged

Wondertan merged 64 commits intomaincelestiaorg/celestia-node:mainfrom hlib/sync-disconnectscelestiaorg/celestia-node:hlib/sync-disconnectsCopy head branch name to clipboardJan 29, 2022

+859-296

Commits

Commits on Jan 27, 2022

• refactor(service/header): do not set validator in constructor but with new AddValidator method on P2PSubscriber

  Wondertan

  committed
  07ffd06

  Copy full SHA for 07ffd06

• fix(service/header): always perform basic validation of header during unmarshalling

  Wondertan

  committed
  0e6a4af

  Copy full SHA for 0e6a4af

• fix(service/header): ensure we skip duplicate header and add a TODO about fork choice rule

  Wondertan

  committed
  91d1a7a

  Copy full SHA for 91d1a7a

• feat(service/header): new Verify to verify unadjacent headers

  Wondertan

  committed
  dec6afe

  Copy full SHA for dec6afe

• fix(service/header): catch up sync if we rcvd valid header far from local head and cache pending headers to be applied adjacently

  Wondertan

  committed
  001a2a4

  Copy full SHA for 001a2a4

• chore: go fmt

  Wondertan

  committed
  0f8d29d

  Copy full SHA for 0f8d29d

• feat(service/header): implement header ranges to cache headers rcvd from pubsub and massive todo list

  Wondertan

  committed
  088eef0

  Copy full SHA for 088eef0

• fix(service/header): TestSuite had a bug in genesis header generation and this commit fixes it

  Wondertan

  committed
  88a1dc9

  Copy full SHA for 88a1dc9

• test(service/header): add two more test for catching-up logic and for requesting of trusted header

  Wondertan

  committed
  c909727

  Copy full SHA for c909727

• fix(service/header): ranges.Add should check for nil head; decouple validateMsg from validate; remove mustSync

  Wondertan

  committed
  4f51347

  Copy full SHA for 4f51347

• changelog: add entry for #334

  Wondertan

  committed
  65e637e

  Copy full SHA for 65e637e

• Update service/header/sync.go

  Show description for a9a9eae
  

  Wondertan

  and

  adlerjohn

  committed
  a9a9eae

  Copy full SHA for a9a9eae

• fix(header): testsuite should start height from one and not from zero

  Wondertan

  committed
  1779637

  Copy full SHA for 1779637

• fix(service/header): use VerifyCommitLightTrusting instead of VerifyCommitLight

  Wondertan

  committed
  b1b03ec

  Copy full SHA for b1b03ec

• fix(service/header): minor log cleanups and bugs

  Wondertan

  committed
  d9f388c

  Copy full SHA for d9f388c

• test(service/header): add Syncer test to assert cached ranges work properly

  Wondertan

  committed
  95499a8

  Copy full SHA for 95499a8

• fix(service/header): fix multiple issues with ranges and improve logging

  Wondertan

  committed
  4ff6cd8

  Copy full SHA for 4ff6cd8

• chore|docs|feat(services/header): move out ranges to a separate file; more docs; Stop for Syncer

  Wondertan

  committed
  dccf976

  Copy full SHA for dccf976

• fix(node/core): invoke HeaderCoreListener

  Wondertan

  committed
  c4aecaf

  Copy full SHA for c4aecaf

• Update service/header/sync.go

  Show description for 8a3923f
  

  Wondertan

  and

  renaynay

  committed
  8a3923f

  Copy full SHA for 8a3923f

• Update service/header/sync.go

  Show description for ddcbb4c
  

  Wondertan

  and

  renaynay

  committed
  ddcbb4c

  Copy full SHA for ddcbb4c

• Update service/header/sync_test.go

  Show description for 23526f1
  

  Wondertan

  and

  renaynay

  committed
  23526f1

  Copy full SHA for 23526f1

• chore(service/header): cleanup todos

  Wondertan

  committed
  b96ad0a

  Copy full SHA for b96ad0a

• fix(header/service): return from listener only on real error

  Wondertan

  committed
  ed5ebab

  Copy full SHA for ed5ebab

• fix(service/header): ensure syncing logic always appends objective head taken from pending cache

  Wondertan

  committed
  307b189

  Copy full SHA for 307b189

• feat(service/header): add TrustingPeriod and new IsExpired func to handle unbonding period for headers

  Wondertan

  committed
  a5ec8f4

  Copy full SHA for a5ec8f4

• test(service/header): cleanup subscriber test

  Wondertan

  committed
  84eeb75

  Copy full SHA for 84eeb75

• feat(service/header): add VerifyError type and remove check from VerifyAdjacent that we are anyway doing in ValidateBasic

  Wondertan

  committed
  534b2b9

  Copy full SHA for 534b2b9

• feat|fix(service/header): add new ErrNonAdjacent and use where applicable; make Store return error on Add if first given header is invalid

  Wondertan

  committed
  ad13b07

  Copy full SHA for ad13b07

• chore(logs): reduce log verbocity for bs:sess

  Wondertan

  committed
  44a5158

  Copy full SHA for 44a5158

• logs(service/header): sane logging for Store

  Wondertan

  committed
  daa8dde

  Copy full SHA for daa8dde

• feat(service/header): update syncing logic to respect trusting period for headers and just make many times better

  Wondertan

  committed
  ae91833

  Copy full SHA for ae91833

• Update service/header/sync_ranges.go

  Show description for 38bed36
  

  Wondertan

  and

  renaynay

  committed
  38bed36

  Copy full SHA for 38bed36

• doc(service/header): add a note about pending cache imposibility to be DOSed

  Wondertan

  committed
  1754746

  Copy full SHA for 1754746

• fix(service/header): remove unused PopHead methods from range and ranges; fix race found on CI

  Wondertan

  committed
  f7b04de

  Copy full SHA for f7b04de

• refactor(service/header): remove mustSync and use buffered chan instead

  Wondertan

  committed
  0f01dd4

  Copy full SHA for 0f01dd4

• logs(service/header): remove syncing loging for idle syncs

  Wondertan

  committed
  8e7e715

  Copy full SHA for 8e7e715

• logs(service/heaeder): does not log ValidationIgnore cases out

  Wondertan

  committed
  9761a64

  Copy full SHA for 9761a64

• logs(service/heaeder): fix Syncer log

  Wondertan

  committed
  32fc6ef

  Copy full SHA for 32fc6ef

• remove accidental celestia binary addition and new .gitignore entry to exclude locally built binaries

  Wondertan

  committed
  7b2d319

  Copy full SHA for 7b2d319

• perf(service/heaeder): increase requstSize to 512

  Wondertan

  committed
  6cc0b56

  Copy full SHA for 6cc0b56

• chore(service/heaeder): fix and improve some logs

  Wondertan

  committed
  d0d40bf

  Copy full SHA for d0d40bf

• refactor(service/heaeder): Verify functions should be methods of ExtendedHeader, where attached header is trusted

  Wondertan

  committed
  163b64a

  Copy full SHA for 163b64a

• Update service/header/sync_ranges.go

  Show description for fac6cf3
  

  Wondertan

  and

  renaynay

  committed
  fac6cf3

  Copy full SHA for fac6cf3

• fix(service/header): revisit lifecycle logic

  Wondertan

  committed
  f2efbe0

  Copy full SHA for f2efbe0

• refactor(service/header): CoreListener should use Broadcaster

  Wondertan

  committed
  f4724dd

  Copy full SHA for f4724dd

• refactor(service/header): header.Subscriber should have AddValidator part of the interface and this commit does that, while updating all the related code

  Wondertan

  committed
  c6b56d5

  Copy full SHA for c6b56d5

• Update service/header/sync.go

  Show description for b814a16
  

  Wondertan

  and

  liamsi

  committed
  b814a16

  Copy full SHA for b814a16

• Update service/header/sync.go

  Show description for 54d5ca3
  

  Wondertan

  and

  renaynay

  committed
  54d5ca3

  Copy full SHA for 54d5ca3

• Update service/header/sync.go

  Show description for 3adce16
  

  Wondertan

  and

  renaynay

  committed
  3adce16

  Copy full SHA for 3adce16

• refactor(service/header): switch over error in incoming

  Wondertan

  committed
  dd1c8bb

  Copy full SHA for dd1c8bb

• Update service/header/sync.go

  Show description for 3777c68
  

  Wondertan

  and

  renaynay

  committed
  3777c68

  Copy full SHA for 3777c68

• chore(service/header): make gocritic happy

  Wondertan

  committed
  635b637

  Copy full SHA for 635b637

• fix(node/fxutil): fix ProvideAs for multiple values

  Wondertan

  committed
  6aa3638

  Copy full SHA for 6aa3638

• refactor(node): provide P2PSubscriber as multiple values using ProvideAs

  Wondertan

  committed
  7cc0daf

  Copy full SHA for 7cc0daf

• docs(service/header): add more docs for syncer

  Wondertan

  committed
  df40544

  Copy full SHA for df40544

• fix(service/header): remove redundant if and fix tests accrodingly

  Wondertan

  committed
  2310011

  Copy full SHA for 2310011

• Update service/header/interface.go

  Show description for 4dbc0d9
  

  Wondertan

  and

  renaynay

  committed
  4dbc0d9

  Copy full SHA for 4dbc0d9

• test(service/header): use require.NoError instead of require.Nil

  Wondertan

  committed
  f0163ac

  Copy full SHA for f0163ac

• chore(service/header): better namings

  Wondertan

  committed
  fee3b65

  Copy full SHA for fee3b65

• Update service/header/sync.go

  Show description for 7eca78f
  

  Wondertan

  and

  renaynay

  authored
  7eca78f

  Copy full SHA for 7eca78f

• Update service/header/sync.go

  Show description for 37b604d
  

  Wondertan

  and

  renaynay

  authored
  37b604d

  Copy full SHA for 37b604d

• Update service/header/interface.go

  Show description for d2dd0a2
  

  Wondertan

  and

  renaynay

  authored
  d2dd0a2

  Copy full SHA for d2dd0a2

Commits on Jan 28, 2022

• Update service/header/interface.go

  Show description for 96280ba
  

  Wondertan

  and

  renaynay

  committed
  96280ba

  Copy full SHA for 96280ba