Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/adr: ADR #003 March 2022 Testnet Design for Celestia Node #244

Merged
merged 15 commits into from
Dec 7, 2021
Merged

docs/adr: ADR #003 March 2022 Testnet Design for Celestia Node #244

merged 15 commits into from
Dec 7, 2021

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Nov 25, 2021 •
edited
Loading

This PR introduces an ADR for the high-level architecture design for celestia-node for the next testnet iteration.

This was referenced Nov 29, 2021
Closed
Closed
@renaynay renaynay linked an issue Nov 29, 2021 that may be closed by this pull request
docs/adr: Finish March 2022 Testnet ADR #249
Closed
@renaynay renaynay mentioned this pull request Nov 29, 2021
Closed
2 tasks
Wondertan
Wondertan reviewed Dec 2, 2021
View reviewed changes
Wondertan
Wondertan reviewed Dec 2, 2021
View reviewed changes
@renaynay renaynay marked this pull request as ready for review December 6, 2021 13:33
@renaynay renaynay requested a review from mattdf as a code owner December 6, 2021 13:33
@renaynay renaynay requested review from liamsi and Wondertan December 6, 2021 13:33
liamsi
liamsi reviewed Dec 7, 2021
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Left a few nits and comments.

renaynay and others added 6 commits December 7, 2021 11:22
@renaynay @Wondertan
sampling vs reconstructing clarification
1d5e7c6 
Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
@renaynay @liamsi
reconstruct block details
e278fbf 
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
@renaynay @liamsi
gossipsub scoring
6906885 
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
@renaynay @liamsi
long range attack
ab753af 
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
@renaynay
tendermint model
7d78a6f
@renaynay
Merge branch 'ADR-march-testnet' of github.com:renaynay/celestia-node…
f33b3ed 
… into ADR-march-testnet
@renaynay renaynay requested a review from liamsi December 7, 2021 10:42
liamsi
liamsi previously approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG 🚀

@liamsi liamsi mentioned this pull request Dec 7, 2021
Closed
2 tasks
This was referenced Dec 7, 2021
Closed
Open
@renaynay @Wondertan
Update docs/adr/adr-003-march2022-testnet.md
8a52135 
Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
@renaynay renaynay requested review from Wondertan and liamsi December 7, 2021 16:04
@renaynay renaynay mentioned this pull request Dec 7, 2021
Closed
Wondertan
Wondertan approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Thank you!

@renaynay renaynay merged commit 8e42e6a into celestiaorg:main Dec 7, 2021
@renaynay renaynay deleted the ADR-march-testnet branch December 7, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi approved these changes

@Wondertan Wondertan Wondertan approved these changes

@mattdf mattdf Awaiting requested review from mattdf

Assignees

@renaynay renaynay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs/adr: Finish March 2022 Testnet ADR
3 participants
@renaynay @liamsi @Wondertan