-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(share): Periodic GC over EDSStore #1359
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSevey
reviewed
Nov 17, 2022
MSevey
reviewed
Nov 17, 2022
c6f2048
to
6cb9cae
Compare
walldiss
reviewed
Nov 24, 2022
Wondertan
reviewed
Nov 28, 2022
Wondertan
previously approved these changes
Nov 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #1359 +/- ##
==========================================
+ Coverage 55.28% 56.07% +0.78%
==========================================
Files 180 188 +8
Lines 10904 11573 +669
==========================================
+ Hits 6028 6489 +461
- Misses 4276 4447 +171
- Partials 600 637 +37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The GC test is racy! will try to fix today |
vgonkivs
reviewed
Nov 29, 2022
walldiss
reviewed
Nov 29, 2022
5 tasks
renaynay
reviewed
Dec 5, 2022
Wondertan
previously approved these changes
Dec 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
renaynay
previously approved these changes
Dec 6, 2022
c153997
renaynay
previously approved these changes
Dec 6, 2022
Wondertan
previously approved these changes
Dec 6, 2022
2738a9a
c153997
to
2738a9a
Compare
walldiss
approved these changes
Dec 6, 2022
renaynay
approved these changes
Dec 6, 2022
Wondertan
approved these changes
Dec 6, 2022
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Overview
This PR implements a goroutine that runs during the lifetime of the
EDSStore
, which callsdgstr.GC
periodically. This garbage collection cleans up shards from transient storage that are available but inactive or errored.The PR is based on #1232 and closes #1116.
Checklist