fix(gateway): switch to separate Listen/Serve #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
added
kind:fix
renaynay
reviewed
Nov 2, 2022
renaynay
previously approved these changes
Nov 2, 2022
|
Also is a part of #1306 |
renaynay
previously approved these changes
Nov 3, 2022
|
Do we still consider moving our rpc test infra to |
MSevey
reviewed
Nov 3, 2022
Wondertan
requested changes
Nov 3, 2022
distractedm1nd
changed the title
distractedm1nd
force-pushed
the
with-server
branch
from
b0159e2 to
b611e25
Compare
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
distractedm1nd
force-pushed
the
with-server
branch
from
b611e25 to
d642adb
Compare
renaynay
approved these changes
Nov 9, 2022
Codecov Report
@@ Coverage Diff @@
## main #1314 +/- ##
==========================================
+ Coverage 54.83% 55.17% +0.34%
==========================================
Files 176 176
Lines 10552 10618 +66
==========================================
+ Hits 5786 5859 +73
+ Misses 4194 4174 -20
- Partials 572 585 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Wondertan
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1286
This is mainly a fix for test flakiness.