fix(ipld/plugin): don't truncate a type byte when it's not in the data #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
renaynay,
vgonkivs and
distractedm1nd
as code owners
45 tasks
|
nice find |
renaynay
previously approved these changes
Oct 4, 2022
|
Should we have a test for this as well? we don't have coverage for Write in the current tests. |
distractedm1nd
suggested changes
Oct 5, 2022
|
I'll add a simple test. Re "secondary documentation": this hasher is not supposed to be used outside. |
Wondertan
force-pushed
the
hlib/fix-hasher-again
branch
from
58afb1c to
4ada8c0
Compare
Codecov Report
@@ Coverage Diff @@
## main #1196 +/- ##
==========================================
- Coverage 60.25% 55.68% -4.57%
==========================================
Files 161 160 -1
Lines 9736 9509 -227
==========================================
- Hits 5866 5295 -571
- Misses 3337 3688 +351
+ Partials 533 526 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Wondertan
force-pushed
the
hlib/fix-hasher-again
branch
from
4ada8c0 to
90562fa
Compare
The code has a special case for the share data with type byte and without. However, it truncates the type byte like it is always there. The #1139 is the first user of share data without a type byte, which uncovered the bug. The type byte causes issues for us again. refactor(ipld/plugin): extract namespaceHasher into a separate file with some additional cleanups In preparation for the upcoming test for the namespaceHasher, we extract it into a separate file. Also, some additional cosmetics were done reducing the API surfuce of the pkg, hiding things that are not supposed to be used outside. test(ipld/plugin): write dummy unit test for the namespaceHasher docs(ipld/plugin): godocs for the namespaceHasher perf(ipld/plugin): use sha256-simd to gain 40% speedup for hash computations
Wondertan
force-pushed
the
hlib/fix-hasher-again
branch
from
90562fa to
c9a3b99
Compare
walldiss
approved these changes
Oct 5, 2022
distractedm1nd
approved these changes
Oct 5, 2022
vgonkivs
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code has a special case for the share data with type byte and without. However, it truncates the type byte like it is always there.
The #1139 is the first user of share data without a type byte, which uncovered the bug. The type byte causes issues for us again.
refactor(ipld/plugin): extract namespaceHasher into a separate file with some additional cleanups
In preparation for the upcoming test for the namespaceHasher, we extract it into a separate file. Also, some additional cosmetics were done
reducing the API surfuce of the pkg, hiding things that are not supposed to be used outside.
test(ipld/plugin): write dummy unit test for the namespaceHasher
docs(ipld/plugin): godocs for the namespaceHasher
perf(ipld/plugin): use sha256-simd to gain 40% speedup for hash computations