-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): Add client wrapper #1195
feat(rpc): Add client wrapper #1195
Conversation
9a7f58b
to
5535eb9
Compare
Codecov Report
@@ Coverage Diff @@
## main #1195 +/- ##
==========================================
- Coverage 60.25% 55.04% -5.21%
==========================================
Files 161 163 +2
Lines 9736 9575 -161
==========================================
- Hits 5866 5271 -595
- Misses 3337 3777 +440
+ Partials 533 527 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
d4c116d
to
6f4a11c
Compare
6f4a11c
to
91f8c0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushing initial review:
should probs be a api/server
and api/client
(unless that breaks deps)
1581fa5
to
093294c
Compare
093294c
to
80854a6
Compare
80854a6
to
0a8692b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
t.Cleanup closer and contexts in tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, unit test failure is known flake that will be resolved with #1286
Based on #1175
Closes #1185
Closes #1186
Also adds the basis for the new rpc tests: