Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd/params): Repair encapsulation for network params #1076

Closed
Tracked by #944
distractedm1nd opened this issue Sep 12, 2022 · 0 comments · Fixed by #1168
Closed
Tracked by #944

fix(cmd/params): Repair encapsulation for network params #1076

distractedm1nd opened this issue Sep 12, 2022 · 0 comments · Fixed by #1168
Assignees
Labels
area:config CLI and config

Comments

@distractedm1nd
Copy link
Collaborator

PR #1073 will temporarily break the encapsulation of the params package by exporting a setter of the default network.

A node option should be made for this, and the default values that were removed in 1073 should be restored once possible without convoluted logic. This means NodeOptions will need to take the node type and network, to be able to set the default values correctly.

This is important and will be completed as part of the refactoring efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:config CLI and config
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant