Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert writing to IPLD during defaultDecideProposal #493

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Aug 16, 2021

Closes: #436

@liamsi liamsi requested a review from Wondertan August 16, 2021 09:04
@liamsi liamsi marked this pull request as ready for review August 16, 2021 09:07
@liamsi liamsi requested a review from evan-forbes as a code owner August 16, 2021 09:07
@Wondertan
Copy link
Member

LGTM, though I feel like this should break something unless we do PutBlock elsewhere, don't remember exactly/

@evan-forbes
Copy link
Member

@Wondertan I think PutBlock is called when saving the block after it is finalized

https://github.com/lazyledger/lazyledger-core/blob/3ba47c2dd58042cd07d3ac740d7fc2ab54fdab9b/consensus/state.go#L1595-L1595

@liamsi
Copy link
Member Author

liamsi commented Aug 16, 2021

@Wondertan if this would break something how would nodes that do not propose work properly?

@liamsi
Copy link
Member Author

liamsi commented Aug 16, 2021

Surprisingly, TestWriteDiscoveryReadData times out 🤔 It's not directly related to the code happening during proposal. I'm glad we are moving this out of this repo.

@Wondertan
Copy link
Member

@evan-forbes, ok, so we merged that PR with blockstore updates. We have so many unfinished PRs in the repo that I lost track of what is merged and what is not. Hopefully, in the new repo, changes will land much quicker 🤞🏻

@liamsi
Copy link
Member Author

liamsi commented Aug 17, 2021

Speaking of open PRs. Do you mind addressing the suggestion in #434 so we can merge it?

@liamsi liamsi force-pushed the ismail/revert_putblock_in_propose branch from 2650953 to abfcba3 Compare August 17, 2021 14:18
@liamsi
Copy link
Member Author

liamsi commented Aug 17, 2021

rebased on master

@liamsi liamsi merged commit d8f9402 into master Aug 17, 2021
@liamsi liamsi deleted the ismail/revert_putblock_in_propose branch August 17, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert writing to local dag during proposal
3 participants