Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package name to SatisPress list #191

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Add package name to SatisPress list #191

merged 1 commit into from
Nov 4, 2022

Conversation

tyrann0us
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
The list of enabled packages ("Settings" -> "SatisPress" -> tab "Repository") includes the Composer name, description, author, package type, etc. However, it does not include the package name. This sometimes makes it hard to identify a package.
Example: A plugin called "WPO365 | SYNC" has Composer name satispress/wpo365-login-premium, another one is called "WPO365 | LOGIN PLUS", Composer name wpo365-login-professional.
Without looking at the code, you won't know which plugin is what.

What is the new behavior (if this is a feature change)?
The package name is printed below the description, above the homepage.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.

Other information:
The name property was already there but unused. I haven't tested the change locally because I did it on the GitHub UI only.

@tyrann0us
Copy link
Contributor Author

Hi @bradyvercher, sorry for being pushy, but is this something you'd consider adding? Thanks!

@bradyvercher bradyvercher merged commit 80f5048 into cedaro:develop Nov 4, 2022
@bradyvercher
Copy link
Member

@tyrann0us No problem, thanks for the PR and your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants