-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Adding particles properties #673
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #673 +/- ##
===========================================
- Coverage 96.66% 96.56% -0.10%
===========================================
Files 123 123
Lines 25375 25401 +26
===========================================
Hits 24527 24527
- Misses 848 874 +26
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, could you please make the minor cosmetic changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I believe this is option (3) right from #654?
I have one question on this implementation in regards to hdf5
and resume
function. I guess there are enums and the IO would be done with no problem right?
Alright, but what about the |
This will be implemented in the fluid or two-phase particles in the future PRs. |
…/particles_properties
@kks32 Should we delete this branch and archive |
Describe the PR
Adding container and general functions in node and particle_base for fluid and two-phase particle purposes.
Related Issues/PRs
#637, #650, and #654
Additional context
Due to the observed performance issue, the current containers and general functions in
node
andparticle_base
are added forfluid
andtwo_phase
particles without changing the solid_particle. Test should be added later in the PR of fluid and two-phase particles.