Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Adding particles properties #673

Closed
wants to merge 10 commits into from

Conversation

bodhinandach
Copy link
Contributor

Describe the PR
Adding container and general functions in node and particle_base for fluid and two-phase particle purposes.

Related Issues/PRs
#637, #650, and #654

Additional context
Due to the observed performance issue, the current containers and general functions in node and particle_base are added for fluid and two_phase particles without changing the solid_particle. Test should be added later in the PR of fluid and two-phase particles.

@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #673 into develop will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #673      +/-   ##
===========================================
- Coverage    96.66%   96.56%   -0.10%     
===========================================
  Files          123      123              
  Lines        25375    25401      +26     
===========================================
  Hits         24527    24527              
- Misses         848      874      +26     
Impacted Files Coverage Δ
include/node.h 100.00% <ø> (ø)
include/node.tcc 88.83% <0.00%> (-7.15%) ⬇️
include/node_base.h 100.00% <ø> (ø)
include/particles/particle.h 100.00% <ø> (ø)
include/particles/particle_base.h 100.00% <ø> (ø)
include/particles/particle_base.tcc 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b20da5...c736d44. Read the comment docs.

Copy link
Contributor

@kks32 kks32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, could you please make the minor cosmetic changes.

@ezrayst ezrayst self-requested a review July 23, 2020 06:44
Copy link
Contributor

@ezrayst ezrayst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I believe this is option (3) right from #654?

I have one question on this implementation in regards to hdf5 and resume function. I guess there are enums and the IO would be done with no problem right?

@bodhinandach
Copy link
Contributor Author

bodhinandach commented Jul 23, 2020

@ezrayst This is for option (2). The option (3) is the PR #654 itself. As for hdf5 and resume, since the solid particle is untouched here, there will be no problem.

@ezrayst
Copy link
Contributor

ezrayst commented Jul 23, 2020

Alright, but what about the hdf5 and resume for fluid phase for instance?

@bodhinandach
Copy link
Contributor Author

Alright, but what about the hdf5 and resume for fluid phase for instance?

This will be implemented in the fluid or two-phase particles in the future PRs.

@bodhinandach bodhinandach changed the title Refactor/particles properties [Refactor] Adding particles properties Jul 28, 2020
@bodhinandach
Copy link
Contributor Author

bodhinandach commented Jul 28, 2020

@kks32 Should we delete this branch and archive refactor/particles?

@bodhinandach bodhinandach deleted the refactor/particles_properties branch July 28, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants