italics-diffing-update

[adamCaxy]

https://caxyinteractive.atlassian.net/browse/ICC-5333

Updated HtmlDiff:processEqualOperation implode function.

[jschroed91]

@adamCaxy This change actually causes issues when diffing "words" that don't have a space between them. For example, when a word is wrapped in parentheses:

[jschroed91]

@adamCaxy I think what actually needs to happen here is to remove the trim calls on the $oldText and $newText arguments in AbstractDiff::__construct.

Since <i> is set to be diffed in isolation, the innerHtml of the i (or em) tag is passed to a new instance of HtmlDiff and trims the extra spaces. This is a problem in situations where there's an intentional space before the closing tag like

<i>italic text with a space </i>that is intentional.

I don't think there's any reason we had trimmed the $oldText/ $newText... that I can recall... so let's remove the trim calls and that should solve this issue I believe.

[jschroed91]

@adamCaxy I actually made these updates in #41, so I will close this PR.

Can you review that PR if you get a chance?