Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed E_DEPRECATED error explicit nullable types #132

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

richardbrinkman
Copy link
Contributor

This PR solves the E_DEPRECATED errors such as:

Caxy\\HtmlDiff\\HtmlDiffConfig::setCacheProvider(): Implicitly marking parameter $cacheProvider as nullable is deprecated, the explicit nullable type must be used instead

in file caxy/php-htmldiff/lib/Caxy/HtmlDiff/HtmlDiffConfig.php

See also https://www.php.net/manual/en/migration84.deprecated.php

After merging this PR, please make a new release as well, such that users of composer can update easily.

Copy link
Member

@jschroed91 jschroed91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request, friend!

@jschroed91 jschroed91 merged commit 5c580b4 into caxy:master Jan 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants