Detecting link changes

[maliayas]

It seems, neither this fork nor the upstream can detect link changes. For example:

-<a href="http://lorem.com">this part doesn't change</a>
+<a href="http://ipsum.com">this part doesn't change</a>

GitHub rich text diff plays nice with this case. Styling is not in the scope of this library but I've captured some screenshots for inspiration. If ahref attribute is changed, GitHub dotted-underlines it and presents a tooltip:

Tooltip:

If link text is also changed, underline and tooltip is gone:

Could we have this detection in this library? Thanks in advance.

[jschroed91]

Of course! I'm working on the table diffing feature now, I will try to sneak this in early this week. Unless someone else wants to put in a PR

[maliayas]

Thanks very much!

[jschroed91]

@maliayas Just merged in updates to detect link changes - I didn't do anything fancy with tooltips since that is out of the scope of this library. But if a link is changed, the old link will be wrapped in a <del class="diffmod diff-href"></del> and the new link will be wrapped in <ins class="diffmod diff-href"></ins>

[maliayas]

Lovely! Problem solved. Btw I've made a code review to be helpful.

[jschroed91]

It's very appreciated! Thank you @maliayas - I will look at your comments and make updates either today or tomorrow morning.

Feel free to suggest additional features/bug fixes in the future, and you are welcome to contribute / open PRs.

We don't have any documentation on contributing at this point, but I hope to do some major clean-up of the code and put together some documentation sometime in the near future.

[maliayas]

Very nice to hear this. Thanks.