Skip to content

Commit

Permalink
publish v0.9.96 with new --scala:2.12 flag
Browse files Browse the repository at this point in the history
  • Loading branch information
carueda committed Feb 28, 2020
1 parent 771d011 commit 0c2034f
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
6 changes: 3 additions & 3 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
2020-02-27 - 0.9.96
2020-02-28 - 0.9.96

- publish v0.9.96 with new `--scala:2.12` flag. Thanks @johanneshiry!

- some adjustments triggered by #59 "switch to scala 2.13 and remove deprecation warning for JavaConverters"
- cross build to 2.13 (besides 2.12)
- fix a bunch of warnings in general
- TODO generate scala code also for 2.13, unless a new flag is used to continue targetting 2.12
as proposed

2019-10-07 - 0.9.95

Expand Down
1 change: 1 addition & 0 deletions src/main/scala/tscfg/gen4tests.scala
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ object gen4tests {
}

opts foreach {
case "--scala:2.12" => genOpts = genOpts.copy(s12 = true)
case "--scala:bt" => genOpts = genOpts.copy(useBackticks = true)
case "--java:getters" => genOpts = genOpts.copy(genGetters = true)
case "--java:optionals" => genOpts = genOpts.copy(useOptionals = true)
Expand Down
2 changes: 1 addition & 1 deletion src/main/scala/tscfg/generators/scala/ScalaGen.scala
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ private[scala] class Accessors {
val scalaCollectionConverter = if (s12) "scala.collection.JavaConverters._" else "scala.jdk.CollectionConverters._"
val methodDef =
s""" private def $methodName(cl:com.typesafe.config.ConfigList, parentPath: java.lang.String, $$tsCfgValidator: $$TsCfgValidator): scala.List[$scalaType] = {
| import $scalaCollectionConverter
| import $scalaCollectionConverter
| cl.asScala.map(cv => $elem).toList
| }""".stripMargin
(methodName, methodDef)
Expand Down
2 changes: 1 addition & 1 deletion src/main/tscfg/example/issue59.spec.conf
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// GenOpts: --scala:12
// GenOpts: --scala:2.12
foolist = [string]

0 comments on commit 0c2034f

Please sign in to comment.