Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: genesis block state update #5

Closed
wants to merge 2 commits into from
Closed

feat: genesis block state update #5

wants to merge 2 commits into from

Conversation

kariy
Copy link
Member

@kariy kariy commented Jan 18, 2025

https://github.com/starkware-libs/cairo-lang/blob/a86e92bfde9c171c0856d7b46580c66e004922f3/src/starkware/starknet/solidity/StarknetState.sol#L19-L39

the solidity counterpart is using i256 but Cairo only has up to 128 bit signed integers. but considering this is used only for the block number, 128-bit is already plenty enough.

the max value for i128 is 170141183460469231731687303715884105727.

@kariy kariy requested a review from glihm as a code owner January 18, 2025 05:39
@kariy kariy marked this pull request as draft January 18, 2025 06:20
@glihm glihm changed the base branch from saya to main February 2, 2025 04:14
glihm added a commit to dojoengine/dojo that referenced this pull request Feb 2, 2025
@kariy kariy changed the base branch from main to saya February 2, 2025 18:18
@kariy
Copy link
Member Author

kariy commented Feb 2, 2025

closing in favour of #7

@kariy kariy closed this Feb 2, 2025
kariy pushed a commit to dojoengine/dojo that referenced this pull request Feb 3, 2025
glihm added a commit to dojoengine/dojo that referenced this pull request Feb 10, 2025
* update piltover on PR cartridge-gg/piltover#5

* update piltover submodule

* update piltover to latest version

* update to latest piltover changes

* ensure katana rpc server can return big responses

* update SNOS program hash

* wip

* update piltover rev

* bump piltover with block-0 correctly handled

* point piltover to main

* feat(rpc): add `max_request_body_size` and `max_response_body_size`

* doc: update comment

* update

* add comments for the two programs hashes

* comments

* fmt

* add bootloader program hash

* add bootloader support for correct piltover configuration

* change piltover rev to main

---------

Co-authored-by: Ammar Arif <evergreenkary@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant