Case insensitive RMagick loading cases multiple require on Mac OS

[kochis]

in carrierwave/processing/rmagick.rb

 module RMagick
      extend ActiveSupport::Concern

      included do
        begin
          require "rmagick"
        rescue LoadError
          require "RMagick"
        rescue LoadError => e
          e.message << " (You may need to install the rmagick gem)"
          raise e
        end
      end

Requiring the lowercase "rmagick" in Mac OS X causes "already initialized" warnings when other libraries require "RMagick".

/Users/kochis/.rvm/gems/ruby-2.0.0-p247@myapp/gems/rmagick-2.13.2/lib/RMagick.rb:44: warning: previous definition of PercentGeometry was here
/Users/kochis/.rvm/gems/ruby-2.0.0-p247@myapp/gems/rmagick-2.13.2/lib/rmagick.rb:45: warning: already initialized constant Magick::AspectGeometry
/Users/kochis/.rvm/gems/ruby-2.0.0-p247@myapp/gems/rmagick-2.13.2/lib/RMagick.rb:45: warning: previous definition of AspectGeometry was here
/Users/kochis/.rvm/gems/ruby-2.0.0-p247@myapp/gems/rmagick-2.13.2/lib/rmagick.rb:46: warning: already initialized constant Magick::LessGeometry
/Users/kochis/.rvm/gems/ruby-2.0.0-p247@myapp/gems/rmagick-2.13.2/lib/RMagick.rb:46: warning: previous definition of LessGeometry was here
...

The file in question being loaded is "RMagick.rb"

In this case, would it make sense to try the "RMagick" require first, and fall back to lowercase? Also, in a case insensitive filesystem, wouldn't it pick up the file either way?

Thanks.

[taavo]

I'm inclined to agree. @bensie?

For reference: we've been doing this since 5bb0e42, and, yup, rmagick uses a capitalized filename.

[kochis]

Just curious, would it make sense to just remove the require for the lowercase name? In a case-insensitive filesystem "RMagick" should still map to "rmagick". And if it were case sensitive, it wouldn't find the rmagick.rb file. Unless there's a case I'm not taking into account.

I have a fix I'm using right now in my fork: fix-rmagic-require-case-sensitivity

[bensie]

I'm inclined to remove the lowercase loader as well. Can't think of any reason that wouldn't work everywhere.