✨ Add possibility to remove hook #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates the --remove|-r command to unlink a previously set hook
carloscuesta
requested changes
Jun 15, 2017
src/gitmoji.js
Outdated
| @@ -75,6 +75,24 @@ class GitmojiCli { | |||
| }; | |||
| } | |||
|
|
|||
| remove() { | |||
| const hookFile = 'prepare-commit-msg'; | |||
There was a problem hiding this comment.
Can you delete hookFile and path constants from remove() and init methods() and create a global commitHookPath constant outside the class. Code duplication is dangerous!
src/gitmoji.js
Outdated
| @@ -75,6 +75,24 @@ class GitmojiCli { | |||
| }; | |||
| } | |||
|
|
|||
| remove() { | |||
| const hookFile = 'prepare-commit-msg'; | |||
| const path = `${process.env.PWD}/.git/hooks/${hookFile}`; | |||
As requested in #53 (review)
|
Sure, think I fixed it now. |
|
Great! Take a look at the build @thibmaek the tests are failing 🚨 |
|
Woops, you're right! Totally forgot to update the test property but should be fine now. Also added a path check for |
carloscuesta
approved these changes
Jun 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces the new command
--remove|-rto unlink a previously set hook. Avoids having to dive into the .git dir in a terminal and remove it there. I love Gitmoji, but sometimes needed to remove it for projects where other people didn't want to use it.It uses
fs#unlinkwhich is an async method that takes the path and a completion callback. Very much likefs#writeFile.Tests