-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0109? | Modular Exponentiation Built-in for Plutus Core #641
Conversation
I would say the use cases are both simplifying the usage of the new BLS builtins. Currently you have to pass in the inverses of scalars because calculating them is prohibitively expensive (close to 10% cpu). In the case of a Plonk implementation made by perturbing. This also allows for signature and pub key aggregation on-chain to be used for other signature schemes like schnorr and ecdsa256k. Currently adding points on those curves is prohibitively expensive since the calculation of adding points requires an inverse calculation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@perturbing thanks for your submission but this isn't fully ready for review unless you add a Path to Active that addresses the items here, and maybe also update the other sections with these particulars:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@perturbing you're all set for CIP number 109... please rename your CIP directory as well 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feedback on this from Plutus reps has been good, and my own question (from last CIP meeting # 79, repeating #641 (review)), about CIP-0035 compliance, appears addressed by 52baecf and d120768 unless @michaelpj thinks anything is missing from Path to Active.
@perturbing this is coming up for review in today's CIP meeting (https://hackmd.io/@cip-editors/80) and I would say it's good to move to Last Check
where the Plutus team & experts can give it further/final confirmation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(meant to include this fix in last review)
Editor consensus to resolve current deadlock from CIP meeting 81 in which Rationale was identified to be "thin" but still not being able to get supplementary writing from authors.
Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…foundation#641) * add readme for modular exponentiation CIP * add other authors * remove unwanted semi-colon * remove unwanted semi-colon * add path to active * add historic note, extra acceptance criteria and formatting * assign official CIP number 109 * change directory name to match assigned cip number * delete old CIP-XXXX dir * pin github links * add implementors * formatting * corrected missing CC license link * formatting * Update CIP-0109/README.md * moved Rationale paragraph to Rationale from Motivation Editor consensus to resolve current deadlock from CIP meeting 81 in which Rationale was identified to be "thin" but still not being able to get supplementary writing from authors. * more detail in satisfaction of implementation requirements Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com> --------- Co-authored-by: Robert Phair <rphair@cosd.com> Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
…foundation#641) * add readme for modular exponentiation CIP * add other authors * remove unwanted semi-colon * remove unwanted semi-colon * add path to active * add historic note, extra acceptance criteria and formatting * assign official CIP number 109 * change directory name to match assigned cip number * delete old CIP-XXXX dir * pin github links * add implementors * formatting * corrected missing CC license link * formatting * Update CIP-0109/README.md * moved Rationale paragraph to Rationale from Motivation Editor consensus to resolve current deadlock from CIP meeting 81 in which Rationale was identified to be "thin" but still not being able to get supplementary writing from authors. * more detail in satisfaction of implementation requirements Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com> --------- Co-authored-by: Robert Phair <rphair@cosd.com> Co-authored-by: Ryan Williams <44342099+Ryun1@users.noreply.github.com>
Hi
This CIP proposes an extension of the current plutus functions to provide support for the efficient calculation of modular exponentiation with inverses.
Rendered proposal on branch.