Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP0025 | retitle to Media NFT Metadata Standard #353

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

Jack-0
Copy link
Contributor

@Jack-0 Jack-0 commented Oct 16, 2022

No description provided.

@Jack-0 Jack-0 changed the title Added Media for clarity Added Media to CIP25's title for clarity. NFT Metadata -> Media NFT Metadata Oct 16, 2022
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SmaugPool this seems consistent with what you recently said here: #345 (comment)

My understanding is that retitling it would be consistent with discussion so far, in which more than one contributor used media support as a rationale for making the NFT images mandatory (because all media were presumed to be representable by an image).

So if @alessandrokonrad has no objections then I would approve this change.

I do need to retitle this for brevity and eliminate the question of whether this is being done for "clarity" (since the existing title isn't really unclear) or "precision", "accuracy", or "specificity" which were the words I would have used.

@rphair rphair changed the title Added Media to CIP25's title for clarity. NFT Metadata -> Media NFT Metadata CIP0025 | retitle to Media NFT Metadata Standard Oct 16, 2022
@rphair rphair requested a review from KtorZ October 16, 2022 14:32
@rphair rphair added the Correction Fixing minor issue or typo label Oct 16, 2022
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this since no objections from author & because the more precise definition is consistent with documentation & usage.

@SmaugPool
Copy link
Contributor

Yes, at some point the idea was to split the CIP in 2, one for the policy/asset structure that could be used for example for fungible tokens too, and one for the media specific metadata:

#85 (comment)

This did not happen so I guess it makes sense to rename the whole CIP instead.

@KtorZ
Copy link
Member

KtorZ commented Oct 20, 2022

Seems fine indeed, we also need to update the top-level README's table.

@rphair
Copy link
Collaborator

rphair commented Oct 20, 2022

thanks @KtorZ ... have added that.

@KtorZ KtorZ merged commit 4ad301a into cardano-foundation:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Correction Fixing minor issue or typo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants