Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0028 | Alonzo Protocol Parameter Description #140

Merged
merged 11 commits into from
Dec 21, 2021
Merged

CIP-0028 | Alonzo Protocol Parameter Description #140

merged 11 commits into from
Dec 21, 2021

Conversation

kevinhammond
Copy link
Contributor

This CIP describes the new protocol parameters that have been implemented for Alonzo. It is an information CIP that builds on the initial parameter settings (CIP-0009).

kevinhammond and others added 9 commits November 23, 2020 17:33
1. Removed CIP preamble as requested by Sebastien

2. Added section on how to update the parameters in future, as requested by the committee.
Fixed table formatting in change paragraph.
Added back header
setting next available non-reserved number, moving status to 'Draft' (internal discussion happening)
CIP moved to proper dir
@matiwinnetou
Copy link
Contributor

+1

@crptmppt
Copy link
Contributor

Do you mean to nest it under CIP-0009?
Otherwise it might make sense to set it as a standalone CIP for readability (so users can refer to specific era parameters)

@kevinhammond
Copy link
Contributor Author

kevinhammond commented Oct 20, 2021

Your call as to whether to nest it or separate it, of course - just let me know. It depends on CIP-0009. I think the correct approach will be to document the changes from the previous version as we go forwards (i.e. the incremental changes).

In case it's about the history, I have a technical problem in that I can only have one fork of the repo (GitHub limits to one fork per account), so I think the commits will always be shown as a chain. There's presumably some way to squash merge once the PR is accepted

@crptmppt crptmppt added tentative CIP State: Last Check Review favourable with disputes resolved; staged for merging. labels Dec 7, 2021
as previously discussed - moving this under CIP 28
@crptmppt crptmppt changed the title Alonzo Protocol Parameter Description CIP-0028 | Alonzo Protocol Parameter Description Dec 7, 2021
@crptmppt crptmppt self-requested a review December 7, 2021 06:52
Title: Protocol Parameters (Alonzo)
Authors: Kevin Hammond <kevin.hammond@iohk.io>
Status: Draft
Type: Informational
Copy link
Contributor

@mark-stopka mark-stopka Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a standard CIP, considering these are parameters that all node implementations should be aware of?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the distinction to limit expectations: as understood this is meant as a "snapshot" CIP (and therefore might best sit as "Informational"). Current conversation around the changed block size since this PR was created is reflecting this.
This is an ongoing conversation really.

@crptmppt crptmppt merged commit 8df9fae into cardano-foundation:master Dec 21, 2021
@rphair rphair removed the State: Last Check Review favourable with disputes resolved; staged for merging. label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants