Skip to content

Commit

Permalink
CIP-0003 clarify Trezor deviation at 24-word mnemonics (#76)
Browse files Browse the repository at this point in the history
  • Loading branch information
refi93 authored Apr 27, 2021
1 parent 27a9108 commit a36e1eb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CIP-0003/Icarus.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,6 @@ function tweakBits(data) {

When used < 24 words, the algorithm is the same as **Icarus**

When using 24 words, **TODO**
When using 24 words, due to incorrect removal of the [BIP-39](https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki#generating-the-mnemonic) entropy checksum bits (via integer division by 8, incorrectly assuming the entropy checksum is always less than 8 bits), the entropy bytes are passed into the `generateMasterKey()` function together with the checksum which for 24-word mnemonics happens to be 8 bits = 1 byte. This bug has been identified and documented in the following Trezor firmware pull request: https://github.com/trezor/trezor-firmware/pull/1388

*Note*: Trezor also allows users to set an additional [passphrase](https://wiki.trezor.io/Passphrase) that works exactly the same as Icarus passphrase

0 comments on commit a36e1eb

Please sign in to comment.