Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra arguments to merlin logger #620

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Add extra arguments to merlin logger #620

merged 1 commit into from
Dec 11, 2024

Conversation

shydefoo
Copy link
Contributor

@shydefoo shydefoo commented Dec 5, 2024 •
edited
Loading

Description

Modifications

  • This PR adds support for those 2 arguments

Tests

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

Release Notes

@shydefoo shydefoo added the bug Something isn't working label Dec 6, 2024
@shydefoo shydefoo self-assigned this Dec 6, 2024
deadlycoconuts
deadlycoconuts approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change! 🚀

@vinoth-gojek vinoth-gojek requested review from a team and removed request for a team December 11, 2024 03:11
@deadlycoconuts deadlycoconuts merged commit 4e1804e into main Dec 11, 2024
33 of 34 checks passed
@deadlycoconuts deadlycoconuts deleted the fix-merlin-logger branch December 11, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deadlycoconuts deadlycoconuts deadlycoconuts approved these changes

@mbruner mbruner Awaiting requested review from mbruner

@bthari bthari Awaiting requested review from bthari

Assignees

@shydefoo shydefoo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shydefoo @deadlycoconuts